Compiling Error In Blowfish

[ChrisM]

// blowfish.cpp C++ class implementation of the BLOWFISH encryption algorithm

#include "blowfish.h"
#include "blowfish.h2" // holds the random digit tables

#define S(x,i) (SBoxes[i][x.w.byte##i])
#define bf_F(x) (((S(x,0) + S(x,1)) ^ S(x,2)) + S(x,3))
#define ROUND(a,b,n) (a.dword ^= bf_F(b) ^ PArray[n])


CBlowFish::CBlowFish ()
{
PArray = new DWORD [18] ;
SBoxes = new DWORD [4][256] ;
}

CBlowFish::~CBlowFish ()
{
delete PArray ;
delete [] SBoxes ;
}

// the low level (private) encryption function
void CBlowFish::Blowfish_encipher (DWORD *xl, DWORD *xr)
{
union aword Xl, Xr ;

Xl.dword = *xl ;
Xr.dword = *xr ;

Xl.dword ^= PArray [0];
ROUND (Xr, Xl, 1) ; ROUND (Xl, Xr, 2) ;
ROUND (Xr, Xl, 3) ; ROUND (Xl, Xr, 4) ;
ROUND (Xr, Xl, 5) ; ROUND (Xl, Xr, 6) ;
ROUND (Xr, Xl, 7) ; ROUND (Xl, Xr, 8) ;
ROUND (Xr, Xl, 9) ; ROUND (Xl, Xr, 10) ;
ROUND (Xr, Xl, 11) ; ROUND (Xl, Xr, 12) ;
ROUND (Xr, Xl, 13) ; ROUND (Xl, Xr, 14) ;
ROUND (Xr, Xl, 15) ; ROUND (Xl, Xr, 16) ;
Xr.dword ^= PArray [17] ;

*xr = Xl.dword ;
*xl = Xr.dword ;
}

// the low level (private) decryption function
void CBlowFish::Blowfish_decipher (DWORD *xl, DWORD *xr)
{
union aword Xl ;
union aword Xr ;

Xl.dword = *xl ;
Xr.dword = *xr ;

Xl.dword ^= PArray [17] ;
ROUND (Xr, Xl, 16) ; ROUND (Xl, Xr, 15) ;
ROUND (Xr, Xl, 14) ; ROUND (Xl, Xr, 13) ;
ROUND (Xr, Xl, 12) ; ROUND (Xl, Xr, 11) ;
ROUND (Xr, Xl, 10) ; ROUND (Xl, Xr, 9) ;
ROUND (Xr, Xl, 8) ; ROUND (Xl, Xr, 7) ;
ROUND (Xr, Xl, 6) ; ROUND (Xl, Xr, 5) ;
ROUND (Xr, Xl, 4) ; ROUND (Xl, Xr, 3) ;
ROUND (Xr, Xl, 2) ; ROUND (Xl, Xr, 1) ;
Xr.dword ^= PArray[0];

*xl = Xr.dword;
*xr = Xl.dword;
}


// constructs the enctryption sieve
void CBlowFish::Initialize (BYTE key[], int keybytes)
{
int i, j ;
DWORD data, datal, datar ;
union aword temp ;

// first fill arrays from data tables
for (i = 0 ; i < 18 ; i++)
PArray [i] = bf_P [i] ;

for (i = 0 ; i < 4 ; i++)
{
for (j = 0 ; j < 256 ; j++)
SBoxes [i][j] = bf_S [i][j] ;
}


j = 0 ;
for (i = 0 ; i < NPASS + 2 ; ++i)
{
temp.dword = 0 ;
temp.w.byte0 = key[j];
temp.w.byte1 = key[(j+1) % keybytes] ;
temp.w.byte2 = key[(j+2) % keybytes] ;
temp.w.byte3 = key[(j+3) % keybytes] ;
data = temp.dword ;
PArray [i] ^= data ;
j = (j + 4) % keybytes ;
}

datal = 0 ;
datar = 0 ;

for (i = 0 ; i < NPASS + 2 ; i += 2)
{
Blowfish_encipher (&datal, &datar) ;
PArray [i] = datal ;
PArray [i + 1] = datar ;
}

for (i = 0 ; i < 4 ; ++i)
{
for (j = 0 ; j < 256 ; j += 2)
{
Blowfish_encipher (&datal, &datar) ;
SBoxes [i][j] = datal ;
SBoxes [i][j + 1] = datar ;
}
}
}

// get output length, which must be even MOD 8
DWORD CBlowFish::GetOutputLength (DWORD lInputLong)
{
DWORD lVal ;

lVal = lInputLong % 8 ; // find out if uneven number of bytes at
the end
if (lVal != 0)
return lInputLong + 8 - lVal ;
else
return lInputLong ;
}

// Encode pIntput into pOutput. Input length in lSize. Returned value
// is length of output which will be even MOD 8 bytes. Input
buffer and
// output buffer can be the same, but be sure buffer length is even MOD
8.
DWORD CBlowFish::Encode (BYTE * pInput, BYTE * pOutput, DWORD lSize)
{
DWORD lCount, lOutSize, lGoodBytes ;
BYTE *pi, *po ;
int i, j ;
int SameDest = (pInput == pOutput ? 1 : 0) ;

lOutSize = GetOutputLength (lSize) ;
for (lCount = 0 ; lCount < lOutSize ; lCount += 8)
{
if (SameDest) // if encoded data is being written into input
buffer
{
if (lCount < lSize - 7) // if not dealing with uneven
bytes at end
{
Blowfish_encipher ((DWORD *) pInput,
(DWORD *) (pInput + 4)) ;
}
else // pad end of data with null bytes to
complete encryption
{
po = pInput + lSize ; // point at byte
past the
end of actual data
j = (int) (lOutSize - lSize) ; // number of
bytes to set to null
for (i = 0 ; i < j ; i++)
*po++ = 0 ;
Blowfish_encipher ((DWORD *) pInput,
(DWORD *) (pInput + 4)) ;
}
pInput += 8 ;
}
else // output buffer not equal to input
buffer, so must copy
{ // input to output buffer prior to encrypting
if (lCount < lSize - 7) // if not dealing with uneven
bytes at end
{
pi = pInput ;
po = pOutput ;
for (i = 0 ; i < 8 ; i++)
// copy bytes to output
*po++ = *pi++ ;
Blowfish_encipher ((DWORD *) pOutput, // now
encrypt them
(DWORD *) (pOutput + 4)) ;
}
else // pad end of data with null bytes to
complete encryption
{
lGoodBytes = lSize - lCount ; // number of
remaining data bytes
po = pOutput ;
for (i = 0 ; i < (int) lGoodBytes ; i++)
*po++ = *pInput++ ;
for (j = i ; j < 8 ; j++)
*po++ = 0 ;
Blowfish_encipher ((DWORD *) pOutput,
(DWORD *) (pOutput + 4)) ;
}
pInput += 8 ;
pOutput += 8 ;
}
}
return lOutSize ;
}

// Decode pIntput into pOutput. Input length in lSize. Input
buffer and
// output buffer can be the same, but be sure buffer length is even MOD
8.
void CBlowFish::Decode (BYTE * pInput, BYTE * pOutput, DWORD lSize)
{
DWORD lCount ;
BYTE *pi, *po ;
int i ;
int SameDest = (pInput == pOutput ? 1 : 0) ;

for (lCount = 0 ; lCount < lSize ; lCount += 8)
{
if (SameDest) // if encoded data is being written into input
buffer
{
Blowfish_decipher ((DWORD *) pInput,
(DWORD *) (pInput + 4)) ;
pInput += 8 ;
}
else // output buffer not equal to input
buffer
{ // so copy input to output before decoding
pi = pInput ;
po = pOutput ;
for (i = 0 ; i < 8 ; i++)
*po++ = *pi++ ;
Blowfish_decipher ((DWORD *) pOutput,
(DWORD *) (pOutput + 4)) ;
pInput += 8 ;
pOutput += 8 ;
}
}
}



Getting the following errors:

--------------------Configuration: blowfish - Win32 Debug--------------------
Compiling...
blowfish.cpp
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(134) : error C2065: 'the' : undeclared identifier
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(134) : error C2146: syntax error : missing ';' before identifier 'end'
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(134) : error C2065: 'end' : undeclared identifier
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(134) : error C2143: syntax error : missing ';' before 'if'
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(144) : error C2146: syntax error : missing ';' before identifier 'and'
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(144) : error C2501: 'buffer' : missing storage-class or type specifiers
C:\Documents and Settings\Chris xxxx\Desktop\blowfish.cpp(144) : fatal error C1004: unexpected end of file found
Error executing cl.exe.

blowfish.exe - 7 error(s), 0 warning(s)



Can someone please help.

[capi]

Hi there ChrisM, don't worry, this particular problem is easily solved. Just a couple of suggestions before we look at it, though: when you paste large amounts of code, it would make it a bit more readable if you wrap it in code tags - they will keep the formatting such as identation, etc. Also, this might topic might be a bit more at home at the Programming and More forum, but that's ok .

[ChrisM]

Thanks. I got it off a website. And your right I dont have much experince but I gotta start somewhere.

[capi]

[data]

hi,

I have a working c code of blowfish written by bruce schenier. Shall paste it here if you still need it.

Data.

[ChrisM]

Id love to look at it...

[data]

hi,

this is the code for blowfish in c. It should run on any C compiler


Data.

[ChrisM]

WOW It looks like a HUGE portion was missing. Thank you.

[data]

good luck with it

Data.

[data]

hi chris,

there is a bug in the code above. You should use the corrected code by bruce schneier, which is linked from

http://www.security-forums.com/forum/viewtopic.php?p=132785#132785

Data.